search

code-423n4 / 2023-04-caviar-findings

9 stars 4 forks source link

QA Report #200

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

Missing setter for changeFee

L

Sanity checks at the constructor

L

Typo mistakes

NC

Unbounded loop in deposit()

L

Inadequate NatSpec

NC

Unspecific compiler version pragma

NC

Non-compliant contract layout with Solidity's Style Guide

NC

Code repeatedly used should be grouped into a modifier

R

Gas griefing/theft is possible on unsafe external call

Ignoring

Events associated with setter functions

NC

_getRoyalty() is not a public view function

Ignoring

Timelock for setter functions

-3

Unrestricted deposit()

L

Uninitialized cooldownPeriod in StolenNftFilterOracle

L

_verifyMessage() does not check if ecrecover return value is 0

-3 wrong codebase

GalloDaSballo commented 1 year ago

1L from dups -6

5L 1R 5NC

6L

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-b