search

code-423n4 / 2023-04-caviar-findings

9 stars 4 forks source link

QA Report #291

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

[L-01] Solmate's SafeTransferLib doesn't check whether the ERC20 contract exists 24 L

[L-02] Lack of two-step update for critical addresses 2 Nc

[L-03] Loss of precision on division 1 L

[L-04] Missing events in sensitive functions 4 NC

[L-05] Gas griefing/theft is possible on an unsafe external call 1 Ignoring

[L-06] Unused/empty receive()/fallback() function 3 Ignoring

[NC-01] Use of abi.encodePacked instead of bytes.concat 7 NC

[NC-02] Parameter omission in events 5 R

[NC-03] Some functions don't follow the Solidity naming conventions 1 NC

[NC-04] Use of floating pragma NC

GalloDaSballo commented 1 year ago

2L 1R 5NC

1L from dups

3L

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-b