search

code-423n4 / 2023-04-caviar-findings

9 stars 4 forks source link

Upgraded Q -> 2 from #680 [1683016840166] #973

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #680 as 2 risk. The relevant finding follows:

A. Fee structure is inconsistent for buys/changes. In buy() and sell() function protocolFee is based on a percentage of the input/output amount but in change() the fee is based on the pool fee not the input amount. It should be based on the input/output amount for consistency

c4-judge commented 1 year ago

GalloDaSballo marked the issue as duplicate of #463

c4-judge commented 1 year ago

GalloDaSballo marked the issue as satisfactory