Judge has assessed an item in Issue #245 as 2 risk. The relevant finding follows:
[L-05] PrivatePoolMetadata.tokenURI is not compliant with EIP721
It implements PrivatePoolMetadata.tokenURI() , a function overriding ERC721's tokenURI().
This function returns the metadata URI of the provided token ID
The issue is that if queried for a token that does not have an owner or has not been minted, it returns the empty string ’’.
src/PrivatePoolMetadata.sol:
16 /// @param tokenId The private pool's token ID.
17: function tokenURI(uint256 tokenId) public view returns (string memory) {
18: // forgefmt: disable-next-item
Judge has assessed an item in Issue #245 as 2 risk. The relevant finding follows:
[L-05] PrivatePoolMetadata.tokenURI is not compliant with EIP721 It implements PrivatePoolMetadata.tokenURI() , a function overriding ERC721's tokenURI().
This function returns the metadata URI of the provided token ID
The issue is that if queried for a token that does not have an owner or has not been minted, it returns the empty string ’’.
src/PrivatePoolMetadata.sol: 16 /// @param tokenId The private pool's token ID. 17: function tokenURI(uint256 tokenId) public view returns (string memory) { 18: // forgefmt: disable-next-item