code-423n4 / 2023-04-caviar-findings

9 stars 4 forks source link

Upgraded Q -> 3 from #222 [1683017474019] #978

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #222 as 3 risk. The relevant finding follows:

[L-02] Downcasting uint or int may result in overflow Consider using OpenZeppelin's SafeCast library to prevent unexpected overflows.

Instances: 2

File: src/PrivatePool.sol

231: virtualNftReserves -= uint128(weightSum);

324: virtualNftReserves += uint128(weightSum);

src/PrivatePool.sol#L231 src/PrivatePool.sol#L324

c4-judge commented 1 year ago

GalloDaSballo marked the issue as duplicate of #167

c4-judge commented 1 year ago

GalloDaSballo marked the issue as partial-25