Closed c4-judge closed 1 year ago
Judge has assessed an item in Issue #222 as 3 risk. The relevant finding follows:
[L-02] Downcasting uint or int may result in overflow Consider using OpenZeppelin's SafeCast library to prevent unexpected overflows.
Instances: 2
File: src/PrivatePool.sol
231: virtualNftReserves -= uint128(weightSum);
324: virtualNftReserves += uint128(weightSum);
src/PrivatePool.sol#L231 src/PrivatePool.sol#L324
GalloDaSballo marked the issue as duplicate of #167
GalloDaSballo marked the issue as partial-25
Judge has assessed an item in Issue #222 as 3 risk. The relevant finding follows:
[L-02] Downcasting uint or int may result in overflow Consider using OpenZeppelin's SafeCast library to prevent unexpected overflows.
Instances: 2
File: src/PrivatePool.sol
231: virtualNftReserves -= uint128(weightSum);
324: virtualNftReserves += uint128(weightSum);
src/PrivatePool.sol#L231 src/PrivatePool.sol#L324