code-423n4 / 2023-04-caviar-findings

9 stars 4 forks source link

Upgraded Q -> 2 from #225 [1683100933057] #994

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #225 as 2 risk. The relevant finding follows:

uint256 exponent = baseToken == address(0) ? 18 - 4 : ERC20(baseToken).decimals() - 4; will revert since ERC20(baseToken).decimals() - 4; causes an underflow

c4-judge commented 1 year ago

GalloDaSballo marked the issue as duplicate of #858

c4-judge commented 1 year ago

GalloDaSballo marked the issue as satisfactory