Closed code423n4 closed 1 year ago
The check starts at https://github.com/code-423n4/2023-04-eigenlayer/blob/main/src/contracts/pods/EigenPod.sol#L354
Invalid assumption.
0xSorryNotSorry marked the issue as low quality report
GalloDaSballo marked the issue as unsatisfactory: Insufficient quality
Lines of code
https://github.com/code-423n4/2023-04-eigenlayer/blob/main/src/contracts/pods/EigenPod.sol#L346-L347
Vulnerability details
Impact
Logical and mathematical flaws might occur due to lack of the check .
Proof of Concept
As per comment in: https://github.com/code-423n4/2023-04-eigenlayer/blob/main/src/contracts/pods/EigenPod.sol#L346
//check if the withdrawal occured after mostRecentWithdrawalBlockNumber
but no check is involved in the code which would cause mathematical flaws in the upcoming calculations.
Tools Used
Manual Audit
Recommended Mitigation Steps
Add this check
require(slot>mostRecentWithdrawalBlockNumber,"withdrawal didn't occur after mostRecentWithdrawalBlockNumber");
at: https://github.com/code-423n4/2023-04-eigenlayer/blob/main/src/contracts/pods/EigenPod.sol#L348Assessed type
Context