search

code-423n4 / 2023-04-eigenlayer-findings

1 stars 1 forks source link

Upgraded Q -> 2 from #454 [1685704791672] #459

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #454 as 2 risk. The relevant finding follows:

L-1 StrategyBase_MIN_NONZERO_TOTAL_SHARES constant doesn't support tokens with 1e6 decimals The minimal value will be too high for tokens with 1e6 decimals (USDT, USDC).

28: uint96 internal constant MIN_NONZERO_TOTAL_SHARES = 1e9; ... 105: uint256 updatedTotalShares = totalShares + newShares; 106: require(updatedTotalShares >= MIN_NONZERO_TOTAL_SHARES, 107: "StrategyBase.deposit: updated totalShares amount would be nonzero but below MIN_NONZERO_TOTAL_SHARES"); https://github.com/code-423n4/2023-04-eigenlayer/blob/5e4872358cd2bda1936c29f460ece2308af4def6/src/contracts/strategies/StrategyBase.sol#L28 https://github.com/code-423n4/2023-04-eigenlayer/blob/5e4872358cd2bda1936c29f460ece2308af4def6/src/contracts/strategies/StrategyBase.sol#L105-L107

c4-judge commented 1 year ago

GalloDaSballo marked the issue as duplicate of #361

c4-judge commented 1 year ago

GalloDaSballo marked the issue as unsatisfactory: Out of scope