Gas Optimizations

[code423n4]

See the markdown file with the details of this report here.

[c4-pre-sort]

0xA5DF marked the issue as high quality report

[luziusmeisser]

Went through all of the issues and implemented the recommendations.

Exceptions:

• "Frankencoin.sol.suggestMinter(): Result of totalSupply() should be cached here(sad path)". Here, totalSupply() is never called during normal operations as the && operator does not evaluate the second part if the first part is already false. So the recommendation would actually increase gas costs.
• "Frankencoin.sol.suggestMinter(): minters[_minter] should be cached in local storage". Second access is not an read, but a write.
• "Using unchecked blocks to save gas" I do not like this optimization as I value concise code higher than saving a little gas here.
• "shorthand if": I usually prefer the longer version to increase readability

[c4-sponsor]

luziusmeisser marked the issue as sponsor confirmed

[c4-judge]

hansfriese marked the issue as selected for report