Lines of code

https://github.com/code-423n4/2023-05-ajna/blob/276942bc2f97488d07b887c8edceaaab7a5c3964/ajna-core/src/RewardsManager.sol#L96

Vulnerability details

[H-01]

RewardsManager.sol contract: ajnaToken_ input address isn't checked if it refers to a contract address.

Vulnerability Details

Impact

all the functions that calls the ajnaToken address will fail/or redirect to a malicious address;hence the rewards will be locked/lost.

Proof of Concept

Instances: 1

File: 2023-05-ajna/ajna-core/src/RewardsManager.sol
Line 96: if (ajnaToken_ == address(0)) revert DeployWithZeroAddress();

Tools Used

Manual Testing.

Recommended Mitigation Steps

Check that ajnaToken_ address is a contract address, this function can be used to check:

function checkSize(address addr) public view returns(uint extSize) {
assembly {
extSize := extcodesize(addr) // returns 0 if EOA, >0 if smart contract
}
}

Assessed type

Invalid Validation

code-423n4 / 2023-05-ajna-findings

RewardsManager.sol contract: ajnaToken\_ input address isn't checked if it refers to a contract address. #362