code-423n4 / 2023-05-ajna-findings

2 stars 0 forks source link

Upgraded Q -> 2 from #410 [1684435015507] #506

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #410 as 2 risk. The relevant finding follows:

[QA-2] Publicly Callable memorializePositions() Function Allows Unauthorized memorization of User Positions memorializePositions() function in positionManager.sol allows any caller to modify position information of any user. This is because the function does not include any ownership check on the provided TokenID.Any user can guess and update a position that they should not have access to. While the downside is that the user must know both the TokenID and position indexes, it is possible for a malicious user to guess the position index and the TokenID which is a predictable value.

https://github.com/code-423n4/2023-05-ajna/blob/276942bc2f97488d07b887c8edceaaab7a5c3964/ajna-core/src/PositionManager.sol#L170-L216

See the markdown file with the details of this report here.

c4-judge commented 1 year ago

Picodes marked the issue as duplicate of #356

c4-judge commented 1 year ago

Picodes marked the issue as duplicate of #488

c4-judge commented 1 year ago

Picodes marked the issue as partial-50

c4-judge commented 1 year ago

Picodes marked the issue as satisfactory

c4-judge commented 1 year ago

Picodes changed the severity to 3 (High Risk)