code-423n4 / 2023-05-asymmetry-mitigation-findings

2 stars 2 forks source link

Mitigation Confirmed for H-01 #23

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Mitigation of H-01: See comments

Link to Issue: https://github.com/code-423n4/2023-03-asymmetry-findings/issues/1098

Comments

The sponsor decided to protect against the "inflation attack" by implementing internal accounting of balances, which prevents the donation of assets used to inflate the value of a share in the attack.

This is a common strategy used to mitigate this type of attack. However, it's important to note that this strategy isn't compatible with rebasing tokens. While the protocol currently doesn't support any derivatives that rely on rebasing tokens (stETH is a rebasing token, but it is used in the form of wstETH), this could become a problem if the protocol decides to integrate a new derivative that uses a rebasing token in the future.

Note: there is a debug import that should be removed here https://github.com/asymmetryfinance/smart-contracts/pull/282/files#diff-e500be4c081e76873145b6e38a37c2d59d6d57bd96cc581c3099582be79ba505R11

c4-judge commented 1 year ago

Picodes marked the issue as satisfactory