search

code-423n4 / 2023-05-asymmetry-mitigation-findings

2 stars 2 forks source link

Mitigation Confirmed for H-02 #24

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Mitigation of H-02: Issue mitigated

Link to Issue: https://github.com/code-423n4/2023-03-asymmetry-findings/issues/1004

Comments

The report mentions a potential case of two different price sources being used to calculate minted shares for the Reth derivative.

This particular issue is correctly mitigated, as:

  1. Removes the confusing _amount parameter in the ethPerDerivative() function.
  2. The ethPerDerivative() implementation in Reth.sol now uses a single price source, as opposed to before where two different paths could be taken depending on a condition.
elmutt commented 1 year ago

thanks

c4-judge commented 1 year ago

Picodes marked the issue as satisfactory