search

code-423n4 / 2023-05-asymmetry-mitigation-findings

2 stars 2 forks source link

Mitigation Confirmed for H-03 #26

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Mitigation of H-03: See comments

Link to Issue: https://github.com/code-423n4/2023-03-asymmetry-findings/issues/703

Comments

This issue and its associated duplicates describe the impossibility of removing a derivative, which may eventually derive in a protocol DoS at different levels if any derivative fails or its underlying protocol gets compromised.

The proposed change is to add a functionality to enable/disable derivatives, and skip the disabled ones in the implementation of the principal functions of the SafEth.sol contract.

While I do think the issue is mitigated in the general scenarios described in H-03 and duplicated, I believe this change introduces new issues, which I'll describe in a separate report ([adriro-NEW-M-01]).

elmutt commented 1 year ago

thanks

c4-judge commented 1 year ago

Picodes marked the issue as satisfactory