search

code-423n4 / 2023-05-asymmetry-mitigation-findings

2 stars 2 forks source link

Mitigation Confirmed for H-04 #27

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Mitigation of H-04: Issue mitigated, see comments

Link to Issue: https://github.com/code-423n4/2023-03-asymmetry-findings/issues/641

Comments

The original issue describes an error in the calculation of ethPerDerivative() for the SfrxEth derivative. The fix described in the report for H-04 is straightforward, however the protocol team decided to change the whole implementation of this function in favor of using Chainlink, probably linked to issue H-08 which describes oracle price manipulation attacks.

While technically the issue described in H-04 is mitigated, as the whole code was replaced, the mitigation introduces a new issue related to the 1:1 frxETH assumption, which is described in a separate report [adriro-NEW-H-01].

elmutt commented 1 year ago

thanks

c4-judge commented 1 year ago

Picodes marked the issue as satisfactory