search

code-423n4 / 2023-05-asymmetry-mitigation-findings

2 stars 2 forks source link

Mitigation Confirmed for Mitigation of M-04: Issue mitigated #36

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Mitigated issue

M-04: Lack of deadline for uniswap AMM

The issue was that the deposit for rETH via Uniswap didn't include a deadline.

Mitigation review

Uniswap is no longer used. Instead RocketSwapRouter is used which swaps what cannot be deposited in the pool on either Uniswap or Balancer, according to provided weights. A 100% Balancer weight has been chosen, which sets the deadline to block.timestamp. (RocketSwapRouter sets the same deadline for Uniswap.)

elmutt commented 1 year ago

thanks

c4-judge commented 1 year ago

Picodes marked the issue as satisfactory