code-423n4 / 2023-05-asymmetry-mitigation-findings

2 stars 2 forks source link

Mitigation Confirmed for M-03 #44

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Mitigation of M-03: Issue not mitigated (intentionally)

Link to Issue: https://github.com/code-423n4/2023-03-asymmetry-findings/issues/1016

Comments

The sponsor decided not to mitigate the issue, the rationale being

We will be manually holding safETH to prevent this, if not redeploy

I believe that is ok. I also think it is worth mentioning a suggestion to implement this ideally through a bootstrap/factory contract or, if not, using a Foundry script. Note that this also comes into play in relation to issue H-01 (liquidity manipulation attack).

elmutt commented 1 year ago

thanks