search

code-423n4 / 2023-05-asymmetry-mitigation-findings

2 stars 2 forks source link

Mitigation of M-06: See comments #49

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Mitigation of M-06: See comments

Link to Issue: https://github.com/code-423n4/2023-03-asymmetry-findings/issues/770

Comments

Sponsor decided not to mitigate the issue with the following comment:

This is as expected

I agree that the issue is TOO broad and some of the described scenarios don't make sense at all (e.g. the approval while redeeming) or are highly unlikely (e.g. RockerPool returning a zero address). I would only consider the following:

  1. SfrxEth staking pause. I've described this issue in MR for issue M-05.
  2. Reth burn in the withdraw() function has been already addressed as part of the mitigation for issue H-07.
elmutt commented 1 year ago

thanks

romeroadrian commented 1 year ago

Submission is duplicated (#48), can be closed