code-423n4 / 2023-05-asymmetry-mitigation-findings

2 stars 2 forks source link

Mitigation Confirmed for H-03 #5

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Fix looks good. Root issue is that derivatives (even those set to 0 weight) must be looped through. To fix this derivatives can now be disabled and skipped.

Note: There is an issue that disabled derivatives that still have a balance will not be rebalanced or have their balance counted. Since all functions are admin restricted it is assumed that the owner is aware of this and that in the event that the balance is recoverable they will first set it's weight to 0 and then rebalance it to clear the balance before disabling it.

c4-judge commented 1 year ago

Picodes marked the issue as satisfactory