search

code-423n4 / 2023-05-juicebox-findings

1 stars 1 forks source link

possible DoS due to lack of validation in the constructor #76

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-05-juicebox/blob/9d0458282511ff269b3b35b5b082b56d5cc08663/juice-buyback/contracts/JBXBuybackDelegate.sol#L118

Vulnerability details

Impact

Immutable variables that are not validated in the constructor generate possible DoS because are immutables (projectToken, pool, jbxTerminal, weth and _projectTokenIsZero) in the uniswapV3SwapCallback(), _swap(), didPay() and _mint() functions of the contract.

Recommended Mitigation Steps

add address(0) validation in the constructor

Assessed type

DoS

dmvt commented 1 year ago

spam

c4-pre-sort commented 1 year ago

dmvt marked the issue as low quality report

c4-judge commented 1 year ago

dmvt marked the issue as unsatisfactory: Invalid