Closed code423n4 closed 1 year ago
https://github.com/code-423n4/2023-05-maia/blob/54a45beb1428d85999da3f721f923cbf36ee3d35/src/ulysses-omnichain/interfaces/IRootRouter.sol#L51 https://github.com/code-423n4/2023-05-maia/blob/54a45beb1428d85999da3f721f923cbf36ee3d35/src/ulysses-omnichain/CoreRootRouter.sol#L379 https://github.com/code-423n4/2023-05-maia/blob/54a45beb1428d85999da3f721f923cbf36ee3d35/src/ulysses-omnichain/MulticallRootRouter.sol#L239 https://github.com/code-423n4/2023-05-maia/blob/54a45beb1428d85999da3f721f923cbf36ee3d35/src/ulysses-omnichain/RootBridgeAgentExecutor.sol#L137
The function anyExecuteDepositSingle() has not been implemented. All implementations only revert(). This call to it will fail.
anyExecuteDepositSingle()
revert()
Here is a search of the repo that shows no correct implementation: https://github.com/search?q=repo:code-423n4/2023-05-maia%20anyExecuteDepositSingle&type=code
Manual
Implement anyExecuteDepositSingle()
Error
trust1995 marked the issue as unsatisfactory: Out of scope
Lines of code
https://github.com/code-423n4/2023-05-maia/blob/54a45beb1428d85999da3f721f923cbf36ee3d35/src/ulysses-omnichain/interfaces/IRootRouter.sol#L51 https://github.com/code-423n4/2023-05-maia/blob/54a45beb1428d85999da3f721f923cbf36ee3d35/src/ulysses-omnichain/CoreRootRouter.sol#L379 https://github.com/code-423n4/2023-05-maia/blob/54a45beb1428d85999da3f721f923cbf36ee3d35/src/ulysses-omnichain/MulticallRootRouter.sol#L239 https://github.com/code-423n4/2023-05-maia/blob/54a45beb1428d85999da3f721f923cbf36ee3d35/src/ulysses-omnichain/RootBridgeAgentExecutor.sol#L137
Vulnerability details
Impact
The function
anyExecuteDepositSingle()
has not been implemented. All implementations onlyrevert()
. This call to it will fail.Proof of Concept
Here is a search of the repo that shows no correct implementation: https://github.com/search?q=repo:code-423n4/2023-05-maia%20anyExecuteDepositSingle&type=code
Tools Used
Manual
Recommended Mitigation Steps
Implement
anyExecuteDepositSingle()
Assessed type
Error