code-423n4 / 2023-05-particle-findings

0 stars 0 forks source link

Gas Optimizations #12

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

c4-judge commented 1 year ago

hansfriese marked the issue as grade-b

wukong-particle commented 1 year ago

G-1, acknowledged, will likely use the pull based withdraw for ETH transfer. Similar to fix suggested in https://github.com/code-423n4/2023-05-particle-findings/issues/31.

G-2, acknowledged, not inlining for readability reasons.

G-3, acknowledged, will consider, gas optimizoooor

G-4, acknowledged, will update, similar to L1 in https://github.com/code-423n4/2023-05-particle-findings/issues/28

c4-sponsor commented 1 year ago

wukong-particle marked the issue as sponsor acknowledged

wukong-particle commented 1 year ago

G-1 fixed (nullified) with https://github.com/Particle-Platforms/particle-exchange-protocol/pull/13 G-4 fixed with https://github.com/Particle-Platforms/particle-exchange-protocol/pull/4