search

code-423n4 / 2023-05-particle-findings

0 stars 0 forks source link

QA Report #18

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

hansfriese commented 1 year ago

L2

c4-judge commented 1 year ago

hansfriese marked the issue as grade-b

wukong-particle commented 1 year ago

L1: dispute, we should revert if OwnerOf(tokenId) === address(this) (sell not successful), not related to burn or not

L2: acknowledged, it's receiver's responsibility to have a way to receive ETH properly (e.g., EOA or multisig)

c4-sponsor commented 1 year ago

wukong-particle marked the issue as sponsor disputed

hansfriese commented 1 year ago

L1: Invalid L2: Low

L 1

wukong-particle commented 1 year ago

L2 fixed with https://github.com/Particle-Platforms/particle-exchange-protocol/pull/17