search

code-423n4 / 2023-05-particle-findings

0 stars 0 forks source link

QA Report #46

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

c4-judge commented 1 year ago

hansfriese marked the issue as grade-b

wukong-particle commented 1 year ago

  1. Acknowledged, similar to https://github.com/code-423n4/2023-05-particle-findings/issues/16

  2. 1000 ETH would be the floor of this NFT collection. Will restrict to this large number for now.

  3. Acknowledged.

  4. Acknowledged the mul, div order, will consider.

  5. We are using WETH at contract initialization time, and it's publicly verifiable. Only reason not hardcoding this in contract is that we need to unit test WETH with forge and we can't use 0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2.

  6. Acknowledged, not checking to save gas. We are not liable if arbitrary sender just sends the contract fund.

  7. Acknowledged, similar to https://github.com/code-423n4/2023-05-particle-findings/issues/23

  8. Acknowledged, the interest accrued during auction should be quite small, our frontend will show linearity for easier understanding, contract will impose https://github.com/code-423n4/2023-05-particle-findings/blob/main/data/adriro-Q.md#L-6

  9. Acknowledged the typos, will update

c4-sponsor commented 1 year ago

wukong-particle marked the issue as sponsor acknowledged

hansfriese commented 1 year ago

1 - Nullified with a similar finding from the same warden 2 - L 3 - L 4 - L 5 - L 6 - L 7 - L 8 - L 9 - N

L7 N1

hansfriese commented 1 year ago

45 downgraded to LOW.

L8 N1

wukong-particle commented 1 year ago

1 mitigated with https://github.com/Particle-Platforms/particle-exchange-protocol/pull/14 3, 4 fixed (nullified) with https://github.com/Particle-Platforms/particle-exchange-protocol/pull/11 7 fixed with https://github.com/Particle-Platforms/particle-exchange-protocol/pull/7 9 fixed with https://github.com/Particle-Platforms/particle-exchange-protocol/pull/25