search

code-423n4 / 2023-05-particle-findings

0 stars 0 forks source link

Gas Optimizations #47

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

c4-judge commented 1 year ago

hansfriese marked the issue as grade-b

wukong-particle commented 1 year ago

  1. Acknowledged, not simplified for readability and maintainability

  2. We are using WETH9 at deployment. Not hardcoding it in contract only because foundry unit tests can't use this fixed address.

  3. Acknowledged, will update, similar to the 7th point in https://github.com/code-423n4/2023-05-particle-findings/blob/main/data/adriro-G.md#particleexchange-contract

c4-sponsor commented 1 year ago

wukong-particle marked the issue as sponsor acknowledged

wukong-particle commented 1 year ago
  1. fixed with https://github.com/Particle-Platforms/particle-exchange-protocol/pull/21