Gas Optimizations

[code423n4]

See the markdown file with the details of this report here.

[c4-pre-sort]

minhquanym marked the issue as high quality report

[CJ42]

I have put "dispute validity", as most of the gas optimisation suggestions are already mentioned in #87 and #87 and we are not in favour with all the optimisations suggested. We approve only 5 / 21 suggestions.

 Ok could be implemented ✅ (5/21)

• G5
• G9
• G11
• G14 (most valid one)
• G15 (most valid one)

For these two, we are a bit skeptical as assembly can decrease code readability and make the logic potentially less safe (assembly removes check performed by the compiler when compiling the source code)

• G13 --> To be tested. We have gas lib, where we can add a custom function for this kind of assignments, writeAddressToStorage(...). I think we can make it in a way that does not break readability.
• G18 --> To be tested. We have gas lib, where we can add a custom function for this, hashToKeccak256(..). I think we can make it in a way that does not break readability.

 Already discussed in #87 and #61 (9/21)

• G1
• G2
• G3
• G6
• G12
• G16
• G19
• G20
• G21

 Considered invalid (3/21)

• G1
• G7
• G8

Not in favour (2/21)

• G13
• G17

[c4-sponsor]

CJ42 marked the issue as sponsor acknowledged

[c4-sponsor]

CJ42 marked the issue as sponsor disputed

[c4-judge]

trust1995 marked the issue as grade-b