search

code-423n4 / 2023-06-lukso-findings

3 stars 1 forks source link

receive() needs to emit the value it receives #17

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-06-lukso/blob/bd49f57c32a522563fc42feeee23c83c8b373405/contracts/Mocks/Reentrancy/SingleReentrancyRelayer.sol#L25

Vulnerability details

Impact

Detailed description of the impact of this finding. the receive functions does not emit any amount sent to it

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept. https://github.com/code-423n4/2023-06-lukso/blob/bd49f57c32a522563fc42feeee23c83c8b373405/contracts/Mocks/Reentrancy/SingleReentrancyRelayer.sol#L25 receive() external payable {}

Tools Used

vscode

Recommended Mitigation Steps

event ValueReceived(uint256); receive() external payable { emit ValueReceived(msg.value); }

Assessed type

Context

c4-pre-sort commented 1 year ago

minhquanym marked the issue as primary issue

c4-pre-sort commented 1 year ago

minhquanym marked the issue as low quality report

minhquanym commented 1 year ago

Inflated severity

c4-judge commented 1 year ago

trust1995 marked the issue as unsatisfactory: Overinflated severity