Condition will not revert when block.timestamp is == to the compared variable

[code423n4]

Lines of code

https://github.com/code-423n4/2023-06-lukso/tree/main/contracts/LSP6KeyManager/LSP6KeyManagerCore.sol#L391-L394

Vulnerability details

Impact

The condition does not revert when block.timestamp is equal to the compared > or < variable. For example, if there is a check for block.timestamp > proposerSignature.expirationTimestamp then there should be a check for cases where block.timestamp is == to proposerSignature.expirationTimestamp

Findings

Total: 2

contracts/LSP6KeyManager/LSP6KeyManagerCore.sol#L391-L394

391:             if (block.timestamp < startingTimestamp) {
...
394:             if (block.timestamp > endingTimestamp) {

Assessed type

Other

[c4-pre-sort]

minhquanym marked the issue as primary issue

[c4-pre-sort]

minhquanym marked the issue as low quality report

[minhquanym]

Seems invalid

[c4-judge]

trust1995 marked the issue as unsatisfactory: Invalid