code-423n4 / 2023-06-lukso-findings

3 stars 1 forks source link

Analysis #90

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

c4-pre-sort commented 1 year ago

minhquanym marked the issue as high quality report

c4-sponsor commented 1 year ago

CJ42 marked the issue as sponsor confirmed

CJ42 commented 1 year ago

Good feedbacks and analysis provided overall. Some of this content might be useful, and we consider including it in our docs.

Improving gas efficiency: Some functions, such as the transferBatch(...) function in the LSP7 and LSP8 standards, could be optimized for gas efficiency.

Adding more functionality to the LSP6KeyManager: Currently, the executeBatch(..) function is not supported, and the relayer can choose the amount of gas provided when interacting with the executeRelayCall(...) functions. Adding support for batch execution and more control over gas provision could improve the functionality and usability of the KeyManager.

These are things that we consider adding in the future. It is in our roadmap.

Regarding the risks reported, these will be considered and investigated in the future.

c4-judge commented 1 year ago

trust1995 marked the issue as grade-a

c4-judge commented 1 year ago

trust1995 marked the issue as satisfactory

c4-judge commented 1 year ago

trust1995 marked the issue as selected for report