search

code-423n4 / 2023-06-stader-findings

1 stars 1 forks source link

Inability to mark validator as FRONT_RUN or INVALID_SIGNATURE #339

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-06-stader/blob/main/contracts/PermissionedNodeRegistry.sol#L254

Vulnerability details

Impact

No way to mark validator keys to marked as FRONT_RUN or INVALID_SIGNATURE in PermissionedNodeRegistry, till there is enough balance in insurance fund to compensate for 1 eth pre deposit made earlier

Tools Used

Recommended Mitigation Steps

Check while making 1 eth deposit in permissioned pool to check there is corresponding fund in insurance fund, in case there is front run or invalid signature by validator

Assessed type

Error

c4-judge commented 1 year ago

Picodes marked the issue as unsatisfactory: Insufficient quality