search

code-423n4 / 2023-06-stader-findings

1 stars 1 forks source link

No stale data check on data being read from POR feed #363

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-06-stader/blob/main/contracts/StaderOracle.sol#L637

Vulnerability details

Impact

Stale data of exchange rate data being used protocol, resulting in loss in terms of ETHX being minted at stale exchange rate (which won't have accounted for new reward)

Recommended Mitigation Steps

Check lastUpdatedAt timestamp and that it is within acceptable range of data update frequency when PORFeed is being used

Assessed type

Other

c4-judge commented 1 year ago

Picodes marked the issue as duplicate of #15

c4-judge commented 1 year ago

Picodes marked the issue as satisfactory