Closed code423n4 closed 1 year ago
https://github.com/code-423n4/2023-06-stader/blob/main/contracts/PermissionlessNodeRegistry.sol#L210-L212 https://github.com/code-423n4/2023-06-stader/blob/main/contracts/StaderInsuranceFund.sol#L36-L38
Eth may not complete successfully. As a result, StaderInsuranceFund will not receive collateral.
Manual audit
Add to StaderInsuranceFund.depositFund() function: if(msg.value == 0) revert Error
ETH-Transfer
Picodes marked the issue as unsatisfactory: Invalid
Lines of code
https://github.com/code-423n4/2023-06-stader/blob/main/contracts/PermissionlessNodeRegistry.sol#L210-L212 https://github.com/code-423n4/2023-06-stader/blob/main/contracts/StaderInsuranceFund.sol#L36-L38
Vulnerability details
Impact
Eth may not complete successfully. As a result, StaderInsuranceFund will not receive collateral.
Tools Used
Manual audit
Recommended Mitigation Steps
Add to StaderInsuranceFund.depositFund() function: if(msg.value == 0) revert Error
Assessed type
ETH-Transfer