search

code-423n4 / 2023-07-pooltogether-findings

12 stars 7 forks source link

Gas Optimizations #317

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

c4-judge commented 1 year ago

Picodes marked the issue as grade-b

PierrickGT commented 1 year ago

G-01: functions are not payable, no need to mark them payable G-02, 03, 04: we would lose in code legibility G-05: handled by safeTransfer G-06: no need to index amounts G-07: constants are assigned, no calculations here G-08: does not save any gas G-09: no need to store in a mapping since the list should be iterable without a key G-10: we would lose in code legibility G-11: does not save any gas G-12: a modifier can't be used for this case G-13: we would lose in code legibility G-14: fixed in the following PR: https://github.com/GenerationSoftware/pt-v5-prize-pool/pull/61 Has been fixed for the TwabController. G-15: constants are always public. G-16: fixed in the following commit: https://github.com/GenerationSoftware/pt-v5-claimer/pull/18/commits/8b45d3872f7385b4fec579446cf0f5e5c307f4ac G-17: has been removed G-18: we would lose in code legibility G-19: we will keep this notation G-20: we would lose in code legibility