search

code-423n4 / 2023-07-pooltogether-findings

12 stars 7 forks source link

QA Report #339

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

c4-judge commented 1 year ago

Picodes marked the issue as grade-b

PierrickGT commented 1 year ago

L1: has been fixed: https://github.com/GenerationSoftware/pt-v5-twab-controller/blob/49240b4fdf715f258104168da5321d675c6af003/src/TwabController.sol#L165 L2: has been fixed: https://github.com/GenerationSoftware/pt-v5-prize-pool/blob/328fd4939ae585a90f7dd0ed91c5a74bbbede9c4/src/PrizePool.sol#L584 L3: handled by safeTransfer: https://github.com/GenerationSoftware/pt-v5-prize-pool/blob/328fd4939ae585a90f7dd0ed91c5a74bbbede9c4/src/PrizePool.sol#L861 NC-1 and 2: fixed in the following PR: https://github.com/GenerationSoftware/pt-v5-twab-controller/pull/24 NC-3: has been removed NC-4: relevant comment NC-5: has been fixed: https://github.com/GenerationSoftware/pt-v5-prize-pool/blob/328fd4939ae585a90f7dd0ed91c5a74bbbede9c4/src/libraries/UD34x4.sol#L26 NC-6: has been removed