Gas Optimizations

[code423n4]

See the markdown file with the details of this report here.

[c4-judge]

Picodes marked the issue as grade-b

[PierrickGT]

G‑01:

• instance 1: would only save gas if we enter in the condition and the transaction would revert anyway.
• instance 2: has been fixed: https://github.com/GenerationSoftware/pt-v5-prize-pool/blob/328fd4939ae585a90f7dd0ed91c5a74bbbede9c4/src/PrizePool.sol#L331
• instance 3: would only save gas if we enter in the condition and the transaction would revert anyway.

G-02: code is more legible when assigning 0 than using delete

G-03:

• instance 1: we can't cache _winners.length cause otherwise we would have to use via-ir
• instance 2: we would lose in code legibility

G-04: has been removed: https://github.com/GenerationSoftware/pt-v5-claimer/blob/7b62fb8c7e40b08631813eec4163a866c3a313bc/src/Claimer.sol#L286 G-05: has been fixed for DrawManager: https://github.com/GenerationSoftware/pt-v5-prize-pool/blob/328fd4939ae585a90f7dd0ed91c5a74bbbede9c4/src/PrizePool.sol#L311 The PrizePool code is already pretty big, so we won't check for address zero to be able to compile without via-ir in the future. G-06: we would lose in code legibility. G-07: would only save gas if we enter in the condition and the transaction would revert anyway. G-08: we would lose in code legibility.

G-09:

• instance 1: fixed in the following PR: https://github.com/GenerationSoftware/pt-v5-prize-pool/pull/60
• instance 2: we would lose in code legibility

G-10: there is not calculation here, we simply assign a value. G-11: has been removed