search

code-423n4 / 2023-08-dopex-findings

3 stars 3 forks source link

Slippage when adding liquidity #1983

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-08-dopex/blob/eb4d4a201b3a75dd4bddc74a34e9c42c71d0d12f/contracts/reLP/ReLPContract.sol#L286-L295

Vulnerability details

Impact

Adding liquidity also requires slippage protection. This comes from the fact that price cannot be changed when adding liquidity, thus liquidity providers also suffer from slippage.

Proof of Concept

Tools Used

VSCode

Recommended Mitigation Steps

add dynamic variables that would be responsible for slippage protection

Assessed type

Uniswap

c4-pre-sort commented 1 year ago

bytes032 marked the issue as duplicate of #1259

bytes032 commented 1 year ago

marking as LQ due to insufficient quality

c4-pre-sort commented 1 year ago

bytes032 marked the issue as low quality report

c4-pre-sort commented 1 year ago

bytes032 marked the issue as duplicate of #1032

c4-judge commented 1 year ago

GalloDaSballo marked the issue as satisfactory

c4-judge commented 1 year ago

GalloDaSballo marked the issue as not a duplicate

c4-judge commented 1 year ago

GalloDaSballo marked the issue as duplicate of #1032

c4-judge commented 1 year ago

GalloDaSballo changed the severity to 2 (Med Risk)

c4-judge commented 1 year ago

GalloDaSballo marked the issue as partial-25