search

code-423n4 / 2023-08-dopex-findings

3 stars 3 forks source link

QA Report #2197

Closed code423n4 closed 10 months ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

c4-pre-sort commented 12 months ago

bytes032 marked the issue as sufficient quality report

GalloDaSballo commented 11 months ago

[L-01] Lack of zero address check in deposit function Low

[L-02] approveContractToSpend will revert for USDT token Low

[L-03] Wrong error code Low

[L-04] bondWithDelegate does not revert with empty arrays as input Low

[L-05] Add check for slippage tolerance to be less than 100% Low

[L-06] Do not use hard-coded addresses Low

[L-07] The event emits zero every time. Low

[L-08] Wrong recipient address during the swap Low

[L-09] rdpxFeePercentage and rdpxBurnPercentage should always be equal to 100% Low

[L-10] The _issueBond function returns a bondId but is never handled Low

[L-11] Minting many tokens with the same Position arguments

c4-judge commented 10 months ago

GalloDaSballo marked the issue as grade-c