search

code-423n4 / 2023-08-dopex-findings

3 stars 3 forks source link

Upgraded Q -> 2 from #2142 [1698131545015] #2229

Closed c4-judge closed 11 months ago

c4-judge commented 11 months ago

Judge has assessed an item in Issue #2142 as 2 risk. The relevant finding follows:

LOW1: No _whenNotPaused() in redeem() Technical Details Almost all state changing functions have _whenNotPaused() in the core contract but it is not the case for redeem().

The NFT it interact with has a pause/unpause functionnality so the function will revert if the NFT is paused thus the impact seems low.

Impact User could still redeem even tho the core contract is paused.

Recommendation Add _whenNotPaused() to the function.

c4-judge commented 11 months ago

GalloDaSballo marked the issue as duplicate of #6

c4-judge commented 11 months ago

GalloDaSballo marked the issue as satisfactory