code423n4 commented 1 year ago

Lines of code

https://github.com/GenerationSoftware/pt-v5-cgda-liquidator/blob/7f95bcacd4a566c2becb98d55c1886cadbaa8897/src/LiquidationPair.sol#L1

Vulnerability details

Impact

No Single Event Emission present in the LiquidationPair.sol Contract

Proof of Concept

Event emission is a way of logging and communicating information from a smart contract to the outside world, they allow smart contracts to index variables in order to rebuild the storage stage, help to automatically update the user interface, and allow for testing of specific variables. More detailed significance can be found in this Alchemy Article

Tools Used

Solidity, Manual Review

Recommended Mitigation Steps

Event Emissions should be implemented where necessary in the LiquidationPair.sol Contract

Assessed type

Access Control

c4-pre-sort commented 1 year ago

raymondfam marked the issue as low quality report

raymondfam commented 1 year ago

QA vividly at best.

HickupHH3 commented 1 year ago

QA: R

c4-judge commented 1 year ago

HickupHH3 changed the severity to QA (Quality Assurance)