search

code-423n4 / 2023-08-pooltogether-mitigation-findings

0 stars 0 forks source link

M-12 MitigationConfirmed #18

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Lines of code

Vulnerability details

Comments

Based on the documentation the highest standard prize tier has odds of 1 (occurs daily) and the canary tier also has the same odds as the highest prize tier. However the previous implementation had an issue where on the canary tier had odds of 1, and the highest standard prize tier had odds of <1.

Mitigation

The updated implementation includes a few changes, including reducing the maximum number of tiers from 15 to 10, making a minor change to the tier odds mathematical formula and allowing the grand prize period to be set in the constructor. The issue identified previously has been resolved, where both the highest standard tier and the canary tier now both have hard-coded odds of 1, so the original issue has been properly resolved.

Conclusion

LGTM

c4-judge commented 1 year ago

Picodes marked the issue as satisfactory