search

code-423n4 / 2023-08-pooltogether-mitigation-findings

0 stars 0 forks source link

M-11 MitigationConfirmed #51

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Lines of code

Vulnerability details

Issue mitigated

About the problem

Vault.mintWithPermit uses permit functionality, which means that initiator should permit correct amount of assets. But because you provide amount of shares that you want to receive, it's not easy to calculate exact amount of assets that is needed to be approved to execute operation.

Solution

Pool together team has decided to remove mintWithPermit function from the contract.

c4-judge commented 1 year ago

Picodes marked the issue as satisfactory