search

code-423n4 / 2023-08-pooltogether-mitigation-findings

0 stars 0 forks source link

M-21 MitigationConfirmed #60

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Lines of code

Vulnerability details

Issue mitigated

About the problem

In this issue warden has noticed, that each time draw is closed, then lastClosedDrawId variable is increased and when user claim prizes, then vault portion is calculated incorrectly and is shifted by 1 draw.

Solution

This issue was fixed by removing +1 shift for the _endDrawId. In the comments developers has discussed, proposed solution by warden and realized, that _startDrawId was calculated correctly. Fix looks good.

c4-judge commented 1 year ago

Picodes marked the issue as satisfactory