search

code-423n4 / 2023-08-reserve-mitigation-findings

0 stars 0 forks source link

M-11 MitigationConfirmed #18

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Lines of code

Vulnerability details

This issue is mitigated.

Explanation of found problem

This issue allows attacker to disable basket when unregistering of an asset that was not in the basket. It was possible to do, by gas amount manipulation. Attacker just needs to send not enough amount of gas to execute basketHandler.quantity function. This will be then caught and basket will be disabled. As result of this, basket was disabled, which paused some system actions and could lead to some unneeded trading losses.

How it was fixed

Reserve team has fixed this, by ensuring, that call was provided with enough amount of gas to be able to call basketHandler.quantity. Now it's not possible to replay attack, as code ensures, that GAS_FOR_BH_QTY amount of gas is sent with basketHandler.quantity call.

c4-judge commented 1 year ago

0xean marked the issue as satisfactory