search

code-423n4 / 2023-08-reserve-mitigation-findings

0 stars 0 forks source link

M-06 MitigationConfirmed #23

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Lines of code

Vulnerability details

Comments

The mitigation deletes the original code (uint192 low, uint192 high) = rsrAsset.price();. And now it uses lot price as the rsr trade low price for rebalance:

            (uint192 lotLow, uint192 lotHigh) = rsrAsset.lotPrice(); // {UoA/RSR}

            if (
                lotHigh > 0 &&
                TradeLib.isEnoughToSell(rsrAsset, rsrAvailable, lotLow, ctx.minTradeVolume)
            ) {
                trade.sell = rsrAsset;
                trade.sellAmount = rsrAvailable;
                trade.prices.sellLow = lotLow;
                trade.prices.sellHigh = lotHigh;
            }
c4-judge commented 1 year ago

0xean marked the issue as satisfactory