code-423n4 / 2023-08-reserve-mitigation-findings

0 stars 0 forks source link

M-11 MitigationConfirmed #27

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Lines of code

Vulnerability details

Comments

The mitigation adds a constant of expanded gas named GAS_FOR_BH_QTY to ensure there are enough gas to call bh.quantity:

uint256 public constant GAS_FOR_BH_QTY = 100_000; 

And it's used in the _reserveGas check:

        require(
            gas > GAS_FOR_DISABLE_BASKET + GAS_FOR_BH_QTY,
            "not enough gas to unregister safely"
        );
c4-judge commented 1 year ago

0xean marked the issue as satisfactory

c4-judge commented 1 year ago

0xean marked the issue as confirmed for report