search

code-423n4 / 2023-08-reserve-mitigation-findings

0 stars 0 forks source link

M-01 MitigationConfirmed #9

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Lines of code

Vulnerability details

Comments

In order to avoid failure to settle auction during the TradingPausedOrFrozen, the mitigation remove the notTradingPausedOrFrozen check from settleTrade function:

function settleTrade(IERC20 sell) public override(ITrading, TradingP1) returns (ITrade trade) {

This avoids lower auction prices due to settlement delays.

c4-judge commented 1 year ago

0xean marked the issue as satisfactory