code-423n4 / 2023-09-asymmetry-findings

2 stars 1 forks source link

QA Report #70

Open c4-submissions opened 9 months ago

c4-submissions commented 9 months ago

See the markdown file with the details of this report here.

0xleastwood commented 9 months ago

L-01 - Not true, AbstractStrategy(vEthAddress).withdraw() will revert if withdrawIdToWithdrawRequestInfo[_withdrawId].withdrawn holds true. I do think this check could potentially be moved within the canWithdraw() function though.

c4-judge commented 9 months ago

0xleastwood marked the issue as grade-a

c4-sponsor commented 9 months ago

elmutt (sponsor) confirmed

MiloTruck commented 9 months ago

Hi 0xleastwood, L-02 here seems to be a duplicate of #48 and L-05 looks like a duplicate of #33, would it be possible for them to be upgraded? Thanks!

0xleastwood commented 9 months ago

Hi 0xleastwood, L-02 here seems to be a duplicate of #48 and L-05 looks like a duplicate of #33, would it be possible for them to be upgraded? Thanks!

Thanks for bringing these to my attention!