search

code-423n4 / 2023-09-delegate-findings

2 stars 1 forks source link

QA Report #277

Closed c4-submissions closed 1 year ago

c4-submissions commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

[L-1] The flashloan is not followed ERC-3156: Flash Loans NC since it's not the same

[L-2] The check checkERC721BeforePull is insufficient Disagree, the check for allowance enforces the zero

[NC-1] No check for address 0 when setApprovalForAll OOS

[NC-2] checkERC1155BeforePull should follow pullERC1155AfterCheck function L

GalloDaSballo commented 1 year ago

1 L, 1NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c