Condition will not revert when block.timestamp is == to the compared variable

[c4-submissions]

Lines of code

https://github.com/code-423n4/2023-09-delegate/blob/main/src/libraries/CreateOffererLib.sol#L328 https://github.com/code-423n4/2023-09-delegate/blob/main/src/libraries/DelegateTokenStorageHelpers.sol#L162

Vulnerability details

Condition will not revert when block.timestamp is == to the compared variable The condition does not revert when block.timestamp is equal to the compared > or < variable. For example, if there is a check for block.timestamp > proposerSignature.expirationTimestamp then there should be a check for cases where block.timestamp is == to proposerSignature.expirationTimestamp

Instances (2):

https://github.com/code-423n4/2023-09-delegate/blob/main/src/libraries/CreateOffererLib.sol#L328

File: example/CreateOffererLib.sol

328:             return block.timestamp + expiryLength;

https://github.com/code-423n4/2023-09-delegate/blob/main/src/libraries/DelegateTokenStorageHelpers.sol#L162

File: example/DelegateTokenStorageHelpers.sol

162:         if (block.timestamp < readExpiry(delegateTokenInfo, delegateTokenId)) {

Assessed type

Other

[c4-judge]

GalloDaSballo changed the severity to QA (Quality Assurance)

[GalloDaSballo]

Off by one

[GalloDaSballo]

L