code-423n4 / 2023-09-delegate-findings

2 stars 1 forks source link

Use _safeMint instead of _mint #289

Closed c4-submissions closed 10 months ago

c4-submissions commented 11 months ago

Lines of code

https://github.com/code-423n4/2023-09-delegate/blob/main/src/PrincipalToken.sol#L33

Vulnerability details

According to openzepplin ERC721, the use of _mint is discouraged, use _safeMint whenever possible. https://docs.openzeppelin.com/contracts/3.x/api/token/erc721#ERC721-_mint-address-uint256-

Instances (1):

https://github.com/code-423n4/2023-09-delegate/blob/main/src/PrincipalToken.sol#L33C3-L37C6

File: example/PrincipalToken.sol

35:         _mint(to, id);

Assessed type

Other

c4-judge commented 11 months ago

GalloDaSballo changed the severity to QA (Quality Assurance)